From dec42e4a65eaf4ae7be920e40479dfd4ae9e5e37 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Herv=C3=A9=20M=C3=A9nager?= <herve.menager@pasteur.fr>
Date: Tue, 5 May 2020 17:58:46 +0200
Subject: [PATCH] Remove GitHub authentication
Because it currently does not work
fix #58
fix #177
---
ippisite/docs/source/configuration.rst | 25 +++++++++++++------------
ippisite/ippisite/settings.py | 2 +-
ippisite/ippisite/settings.template.py | 2 +-
3 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/ippisite/docs/source/configuration.rst b/ippisite/docs/source/configuration.rst
index bf51e9f5..53d9bf25 100644
--- a/ippisite/docs/source/configuration.rst
+++ b/ippisite/docs/source/configuration.rst
@@ -51,20 +51,21 @@ You can then navigate to the django admin interface of iPPI-DB, and create an en
.. image:: img/ORCID_conf_7.png
:width: 100%
-GitHub authentication configuration
+.. GitHub authentication is commented because it does not currently work
+.. GitHub authentication configuration
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
-The configuration for GitHub authentication follows the same principle: configure the app on the provider website, then enter the provided `Client ID` and `Client secret`
-on the django admin interface website.
-
-.. image:: img/Github_conf_1.png
- :width: 100%
-
-.. image:: img/Github_conf_2.png
- :width: 100%
-
-.. image:: img/Github_conf_3.png
- :width: 100%
+.. The configuration for GitHub authentication follows the same principle: configure the app on the provider website, then enter the provided `Client ID` and `Client secret`
+ on the django admin interface website.
+..
+ .. image:: img/Github_conf_1.png
+ :width: 100%
+..
+ .. image:: img/Github_conf_2.png
+ :width: 100%
+..
+ .. image:: img/Github_conf_3.png
+ :width: 100%
diff --git a/ippisite/ippisite/settings.py b/ippisite/ippisite/settings.py
index 68cfb4e4..959b7161 100644
--- a/ippisite/ippisite/settings.py
+++ b/ippisite/ippisite/settings.py
@@ -55,7 +55,7 @@ INSTALLED_APPS = [
"allauth",
"allauth.account",
"allauth.socialaccount",
- "allauth.socialaccount.providers.github",
+ #"allauth.socialaccount.providers.github",
"allauth.socialaccount.providers.orcid",
]
diff --git a/ippisite/ippisite/settings.template.py b/ippisite/ippisite/settings.template.py
index 7fa61aba..ed2bd61d 100644
--- a/ippisite/ippisite/settings.template.py
+++ b/ippisite/ippisite/settings.template.py
@@ -57,7 +57,7 @@ INSTALLED_APPS = [
"allauth",
"allauth.account",
"allauth.socialaccount",
- "allauth.socialaccount.providers.github",
+ #"allauth.socialaccount.providers.github",
"allauth.socialaccount.providers.orcid",
]
--
GitLab