From 28bfc90c7f02ce6f6f961d6d5bfce642e604082c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Laurent?= <francois.laurent@posteo.net>
Date: Thu, 21 Nov 2024 17:03:38 +0100
Subject: [PATCH] fix: argument parsing broken for train
---
src/Taggers.jl | 27 +++++++++------------------
1 file changed, 9 insertions(+), 18 deletions(-)
diff --git a/src/Taggers.jl b/src/Taggers.jl
index 206406f..ddae1b3 100644
--- a/src/Taggers.jl
+++ b/src/Taggers.jl
@@ -226,26 +226,17 @@ function parsekwargs!(args, kwargs)
return args
end
-function run(tagger, switch, kwargs, extra...)
- args = Any["--model-instance", tagger.model_instance]
- for (p, v) in pairs(extra)
- if !isnothing(v)
- push!(args, p)
- push!(args, v)
- end
- end
- if !isnothing(tagger.sandbox)
- push!(args, "--sandbox")
- push!(args, tagger.sandbox)
- end
+function run(tagger, switch, kwargs)
+ kwargs["model_instance"] = tagger.model_instance
+ kwargs["sandbox"] = tagger.sandbox
+ args = Any[]
parsekwargs!(args, kwargs)
cmd = tagging_backend_command(tagger)
- Base.run(Cmd(`$(cmd) $(switch) $(args)`; dir=tagger.backend_dir))
+ Base.run(Cmd(`$cmd $switch $args`; dir=tagger.backend_dir))
end
-function train(tagger::Tagger; pretrained_instance=nothing, kwargs...)
- ret = run(tagger, "train", kwargs,
- "--pretrained-model-instance" => pretrained_instance)
+function train(tagger::Tagger; kwargs...)
+ ret = run(tagger, "train", kwargs)
@assert isdir(modeldir(tagger))
return ret
end
@@ -253,8 +244,8 @@ end
predict(tagger::Tagger; kwargs...) = run(tagger, "predict", kwargs)
function finetune(tagger::Tagger; original_instance=nothing, kwargs...)
- ret = run(tagger, "finetune", kwargs,
- "--original-model-instance" => original_instance)
+ kwargs["original_model_instance"] = original_instance
+ ret = run(tagger, "finetune", kwargs)
@assert isdir(modeldir(tagger))
return ret
end
--
GitLab