Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • L liquidprompt
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 33
    • Issues 33
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Johann Dreo
  • liquidprompt
  • Merge requests
  • !556

_lp_connection: correctly detect local connection if X11 display doesn't start with colon

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Johann Dreo requested to merge github/fork/mpasternacki/fix/_lp_connection-DISPLAY into master Aug 28, 2018
  • Overview 2
  • Commits 1
  • Pipelines 0
  • Changes 1

Created by: mpasternacki

FreeBSD with slim display manager sets DISPLAY=unix:0.0, which is currently detected as telnet session and displayed in ugly red.

[japhy:~] % who am i
japhy            pts/3        28 Aug 16:36 (unix:0.0)
[japhy:~] % echo $DISPLAY
unix:0.0
[japhy:~] % uname -a
FreeBSD sophon.local 12.0-CURRENT FreeBSD 12.0-CURRENT #0 r333486: Fri May 11 12:32:05 UTC 2018     maciej@hatter:/usr/obj/usr/src/amd64.amd64/sys/GENERIC-NODEBUG  amd64

It's quite likely that this renders the previous condition (x"$whoami" = *'(:'*) redundant, but I didn't want to remove it without confirmation.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: github/fork/mpasternacki/fix/_lp_connection-DISPLAY